-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8378: Fixed handling non-indexable field types #250
Merged
alongosz
merged 2 commits into
3.3
from
IBX-8378_Fieldtype_must_implement_Indexable_if_using_Solr
Jul 9, 2024
Merged
IBX-8378: Fixed handling non-indexable field types #250
alongosz
merged 2 commits into
3.3
from
IBX-8378_Fieldtype_must_implement_Indexable_if_using_Solr
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
alongosz
reviewed
Jun 11, 2024
lib/FieldMapper/ContentTranslationFieldMapper/BlockDocumentsContentFields.php
Show resolved
Hide resolved
alongosz
approved these changes
Jun 12, 2024
lib/FieldMapper/ContentTranslationFieldMapper/BlockDocumentsContentFields.php
Show resolved
Hide resolved
alongosz
changed the title
IBX-8378: Fieldtype must implement Indexable if using Solr
IBX-8378: Fixed handling non-indexable field types
Jun 12, 2024
konradoboza
approved these changes
Jun 27, 2024
tomaszszopinski
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on IbexaDXP 3.3 commerce.
alongosz
deleted the
IBX-8378_Fieldtype_must_implement_Indexable_if_using_Solr
branch
July 10, 2024 09:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a custom field type, it must implement Indexable (even though the field content should not be searchable) or else the solr bundle will return exception:
Legacy search and Elastic search will not throw any errors.
It is a bit unclear to me if it is intended that all fieldtypes must implement Indexable or not.
pro:
cons:
So either documentation should be updated or Solr bundle should behave as the other search engine adapters. This PR adds support in Solr for not having to implement Indexable